chore: add typescript-eslint/require-await rule #9116
Merged
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MINSEONG KIM <[email protected]>
Co-authored-by: MINSEONG KIM <[email protected]>
…undant require-await rule
|
View your CI Pipeline Execution ↗ for commit 982e271.
☁️ Nx Cloud last updated this comment at |
manudeli
commented
May 7, 2025
| @@ -9,6 +8,7 @@ export default [ | |||
| rules: { | |||
| 'cspell/spellchecker': 'off', | |||
| '@typescript-eslint/no-unnecessary-condition': 'off', | |||
| '@typescript-eslint/require-await': 'off', | |||
There was a problem hiding this comment.
@minseong0324 I'm going to treat it like this now.
We can apply @typescript-eslint/require-await rule as error to the rest by turning off the this rule only for @tanstack/query-codemods
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9116 +/- ##
=======================================
Coverage 44.55% 44.55%
=======================================
Files 207 207
Lines 8159 8159
Branches 1829 1829
=======================================
Hits 3635 3635
Misses 4081 4081
Partials 443 443 🚀 New features to boost your workflow:
|
minseong0324
added a commit
to minseong0324/Tanstack-query
that referenced
this pull request
May 7, 2025
Co-authored-by: MINSEONG KIM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.