Add/update baseline .cfignore files #390
Conversation
| Properties | ||
|
|
||
| # files specific this sample | ||
| .tanzuignore |
There was a problem hiding this comment.
Should this be moved to the "Common files that don't need to be pushed" section?
There was a problem hiding this comment.
Can you also update the .tanzuignore file in the Configuration sample directory, then replicate it to the connector samples?
There is also a .dockerignore file in the Configuration samples directory. Does it serve any purpose, or should it be deleted?
There was a problem hiding this comment.
I'm not sure what to do with .tanzuignore, so I wanted to just generally leave it as-is and consider it a sample-specific file for now since we have no plans to add more of them.
I don't see any value in the .dockerignore file, I'll remove it
There was a problem hiding this comment.
Based on recent developments, I recommend deleting the file and no longer referencing it.
| # DotNet | ||
| bin | ||
| obj | ||
| publish |
There was a problem hiding this comment.
Upon reviewing relevant entries in https://github.com/github/gitignore/blob/main/VisualStudio.gitignore, I noticed some differences, such as publish/, which indicates that it should match directories only. Does the .cfignore format also support that?
There was a problem hiding this comment.
The only file I saw in in that directory in our samples was launchSettings.json. I suppose the file name should be here rather than the directory
There was a problem hiding this comment.
That looks like a response to another comment :)
| # Common files that don't need to be pushed | ||
| config | ||
| *.http | ||
| manifest-windows.yml |
There was a problem hiding this comment.
This could be manifest*.yml, in case we add more variations in the future.
There was a problem hiding this comment.
It could be, but we could also change it if/when that happens
There was a problem hiding this comment.
My concern is that it probably never happens, as we typically don't look at these files. That leads to including unintended files, which succeeds, so we won't be notified. Unless there's a potential reason to include such files that I can't think of, I prefer to widen the match.
fixes #350