Skip to content

style(Comment): update typings and propTypes usage #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2017
Merged

Conversation

layershifter
Copy link
Member

This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.

@codecov-io
Copy link

codecov-io commented Feb 6, 2017

Codecov Report

Merging #1293 into master will not change coverage.

@@           Coverage Diff           @@
##           master    #1293   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         140      140           
  Lines        2394     2394           
=======================================
  Hits         2388     2388           
  Misses          6        6
Impacted Files Coverage Δ
src/views/Comment/CommentAction.js 100% <ø> (ø)
src/views/Comment/CommentAvatar.js 100% <ø> (ø)
src/views/Comment/CommentAuthor.js 100% <ø> (ø)
src/views/Comment/CommentActions.js 100% <ø> (ø)
src/views/Comment/Comment.js 100% <ø> (ø)
src/views/Comment/CommentGroup.js 100% <ø> (ø)
src/views/Comment/CommentMetadata.js 100% <ø> (ø)
src/views/Comment/CommentContent.js 100% <100%> (ø)
src/views/Comment/CommentText.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070178e...cb3b56e. Read the comment docs.

Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple minor doc block grammar changes. Will merge on pass, thanks!

@levithomason levithomason merged commit c9f6dcc into master Feb 11, 2017
@levithomason levithomason deleted the style/comment branch February 11, 2017 06:15
@levithomason
Copy link
Member

Released in [email protected].

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
* style(Comment): update typings and propTypes usage

* docs(CommentContent): update component description

* docs(CommentText): update component description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants