-
Notifications
You must be signed in to change notification settings - Fork 103
feat(cli): add experimental patch-compat-table
command
#7341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lukas742
wants to merge
10
commits into
main
Choose a base branch
from
feat/cli-patch-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6691958
feat(cli): add experimental `patch-compat-table` command
Lukas742 fe5c0e2
formatting
Lukas742 9ed2e1a
Update README.md
Lukas742 8aacff3
Merge branch 'main' into feat/cli-patch-table
Lukas742 dadbff4
Update README.md
Lukas742 ddd4dba
Merge branch 'feat/cli-patch-table' of https://github.com/SAP/ui5-web…
Lukas742 50395bd
Update README.md
Lukas742 8ff656e
Update @ui5+webcomponents-react-compat+2.10.0.patch
Lukas742 d22f746
Update index.ts
Lukas742 accc031
Merge branch 'main' into feat/cli-patch-table
Lukas742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
packages/cli/patches/@ui5+webcomponents-compat+2.10.0.patch
Large diffs are not rendered by default.
Oops, something went wrong.
38 changes: 38 additions & 0 deletions
38
packages/cli/patches/@ui5+webcomponents-react-compat+2.10.0.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
diff --git a/node_modules/@ui5/webcomponents-react-compat/dist/components/Table/index.js b/node_modules/@ui5/webcomponents-react-compat/dist/components/Table/index.js | ||
index 250a159..3e6d6c2 100644 | ||
--- a/node_modules/@ui5/webcomponents-react-compat/dist/components/Table/index.js | ||
+++ b/node_modules/@ui5/webcomponents-react-compat/dist/components/Table/index.js | ||
@@ -56,7 +56,7 @@ import { withWebComponent } from '@ui5/webcomponents-react-base/dist/wrapper/wit | ||
* | ||
* __Note__: This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/) | ||
*/ | ||
-const Table = withWebComponent('ui5-table', [ | ||
+const Table = withWebComponent('ui5-table-v1', [ | ||
'accessibleName', | ||
'accessibleNameRef', | ||
'busyDelay', | ||
diff --git a/node_modules/@ui5/webcomponents-react-compat/dist/components/TableCell/index.js b/node_modules/@ui5/webcomponents-react-compat/dist/components/TableCell/index.js | ||
index 2e5338f..cce3387 100644 | ||
--- a/node_modules/@ui5/webcomponents-react-compat/dist/components/TableCell/index.js | ||
+++ b/node_modules/@ui5/webcomponents-react-compat/dist/components/TableCell/index.js | ||
@@ -6,6 +6,6 @@ import { withWebComponent } from '@ui5/webcomponents-react-base/dist/wrapper/wit | ||
* | ||
* __Note__: This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/) | ||
*/ | ||
-const TableCell = withWebComponent('ui5-table-cell', [], [], [], []); | ||
+const TableCell = withWebComponent('ui5-table-cell-v1', [], [], [], []); | ||
TableCell.displayName = 'TableCell'; | ||
export { TableCell }; | ||
diff --git a/node_modules/@ui5/webcomponents-react-compat/dist/components/TableRow/index.js b/node_modules/@ui5/webcomponents-react-compat/dist/components/TableRow/index.js | ||
index 6d568f3..e5ace7d 100644 | ||
--- a/node_modules/@ui5/webcomponents-react-compat/dist/components/TableRow/index.js | ||
+++ b/node_modules/@ui5/webcomponents-react-compat/dist/components/TableRow/index.js | ||
@@ -6,6 +6,7 @@ import { withWebComponent } from '@ui5/webcomponents-react-base/dist/wrapper/wit | ||
* | ||
* __Note__: This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/) | ||
*/ | ||
-const TableRow = withWebComponent('ui5-table-row', ['type'], ['navigated', 'selected'], [], []); | ||
+const TableRow = withWebComponent('ui5-table-row-v1', ['type'], ['navigated', 'selected'], [], []); | ||
TableRow.displayName = 'TableRow'; | ||
export { TableRow }; | ||
\ No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be pin these deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I would see flexibility over "predictability" since they're currently only required for the patch.