der: remove generic <T> from Reader::finish

[dishmaker]

Depends on:

• ecdsa: der: use impl EncodeValue/DecodeValue on SignatureRef signatures#965

Before:

./formats$ cargo llvm-lines -p der --all-features | head -n 10
  Lines                Copies              Function name
  -----                ------              -------------
  68510                1007                (TOTAL)
   6422 (9.4%,  9.4%)    29 (2.9%,  2.9%)  der::asn1::any::AnyRef::decode_as
   3334 (4.9%, 14.2%)    33 (3.3%,  6.2%)  <der::reader::slice::SliceReader as der::reader::Reader>::finish
   2310 (3.4%, 17.6%)    10 (1.0%,  7.1%)  der::asn1::integer::value_cmp

After:

./formats$ cargo llvm-lines -p der --all-features | head -n 10
  Lines                Copies             Function name
  -----                ------             -------------
  65769                975                (TOTAL)
   6879 (10.5%, 10.5%)  29 (3.0%,  3.0%)  der::asn1::any::AnyRef::decode_as
   2310 (3.5%, 14.0%)   10 (1.0%,  4.0%)  der::asn1::integer::value_cmp
   1768 (2.7%, 16.7%)    1 (0.1%,  4.1%)  der::tag::_::<impl arbitrary::Arbitrary for der::tag::Tag>::try_size_hint::{{closure}}

[tarcieri]

@dishmaker can you get this green? Looks like there are some needed changes

[baloo]

clippy can be fixed here, but otherwise to fix cms and x509 we'll need to adopt the breaking change in ecdsa first and make a release there, then a release of p256 and others. This is going to be painful :(

(and we'll need to splif off the workspace here again)

What's blocking ecdsa from an rc release?

[tarcieri]

@baloo the latest ecdsa release is v0.17.0-rc.0

[baloo]

so the plan would be:

• Fixup clippy, split off the workspace x509-cert,cms,x509-tsp,...
• Release der der: v0.8.0-rc.4 #1863
• Fix ecdsa breakage ecdsa: der: use impl EncodeValue/DecodeValue on SignatureRef signatures#965
• release ecdsa v0.17.0-rc.1
• Reunite the workspace
• Release x509 x509-cert: 0.3.0-rc.0 #1861
• ...
• Dominate the world