Skip to content

[CoreAudio] Support I16 and U16 sample formats #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HybridEidolon opened this issue Nov 1, 2017 · 0 comments · Fixed by #195
Closed

[CoreAudio] Support I16 and U16 sample formats #180

HybridEidolon opened this issue Nov 1, 2017 · 0 comments · Fixed by #195

Comments

@HybridEidolon
Copy link
Contributor

This isn't strictly necessary for support on macOS, but the current implementation only offers F32 sample support. For parity with WASAPI and ALSA, the CoreAudio backend should offer I16 and U16 by setting the underlying Audio Unit's stream format to the appropriate format, and setting the PCM flags as necessary.

mitchmindtree added a commit to mitchmindtree/cpal that referenced this issue Jan 27, 2018
Based on RustAudio#195.

Also implements proper handling of the given `Endpoint` in the
macos implementation of the `build_voice` method.

Updates to the latest coreaudio-sys and coreaudio-rs which include the
additional necessary frameworks.

Also adds a line that prints the name of the default device in the
`enumeration.rs` example.

Updates the CHANGELOG for this PR.

Closes RustAudio#194.
Related to RustAudio#180.

Related external issues:

- RustAudio/coreaudio-sys#4
- RustAudio/coreaudio-rs#57
mitchmindtree added a commit to mitchmindtree/cpal that referenced this issue Jan 27, 2018
Based on RustAudio#195.

Also implements proper handling of the given `Endpoint` in the
macos implementation of the `build_voice` method.

Updates to the latest coreaudio-sys and coreaudio-rs which include the
additional necessary frameworks.

Also adds a line that prints the name of the default device in the
`enumeration.rs` example.

Updates the CHANGELOG for this PR.

Closes RustAudio#194.
Related to RustAudio#180.

Related external issues:

- RustAudio/coreaudio-sys#4
- RustAudio/coreaudio-rs#57
mitchmindtree added a commit to mitchmindtree/cpal that referenced this issue Jan 27, 2018
Based on RustAudio#195.

Also implements proper handling of the given `Endpoint` in the
macos implementation of the `build_voice` method.

Updates to the latest coreaudio-sys and coreaudio-rs which include the
additional necessary frameworks.

Also adds a line that prints the name of the default device in the
`enumeration.rs` example.

Updates the CHANGELOG for this PR.

Closes RustAudio#194.
Related to RustAudio#180.

Related external issues:

- RustAudio/coreaudio-sys#4
- RustAudio/coreaudio-rs#57
mitchmindtree added a commit to mitchmindtree/cpal that referenced this issue Jan 28, 2018
Based on RustAudio#195.

Also implements proper handling of the given `Endpoint` in the
macos implementation of the `build_voice` method.

Updates to the latest coreaudio-sys and coreaudio-rs which include the
additional necessary frameworks.

Also adds a line that prints the name of the default device in the
`enumeration.rs` example.

Updates the CHANGELOG for this PR.

Closes RustAudio#194.
Related to RustAudio#180.

Related external issues:

- RustAudio/coreaudio-sys#4
- RustAudio/coreaudio-rs#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants