Skip to content

Sort errors in error.rs in order #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sladyn98
Copy link

@sladyn98 sladyn98 commented Jun 5, 2021

Sorts the errors in errors.rs according to include/uapi/asm-generic/errno-base.h

Closes #309

@ksquirrel
Copy link
Member

Review of fe5f11ef18d1:

  • ❌ Commit fe5f11e: The commit title is longer than 75 characters.
  • ❌ Commit fe5f11e: The commit message needs to be at least 3 lines long: title, empty line, signature.

@TheSven73
Copy link
Collaborator

Thanks for the contribution!! 💯

However I don't think this PR can or should close #309: it does not add the remaining errors.

@sladyn98
Copy link
Author

sladyn98 commented Jun 5, 2021

@TheSven73 Yes, I am adding the remaining in a second commit :)

@TheSven73
Copy link
Collaborator

That's cool, but why not add both commits to the same PR? Or is that the plan?

@ojeda
Copy link
Member

ojeda commented Jun 5, 2021

Approved CI to run -- thanks for joining the project! :)

@ojeda
Copy link
Member

ojeda commented Jun 7, 2021

@TheSven73 Yes, I am adding the remaining in a second commit :)

To clarify: the problem is that the PR closes automatically the issue if you write "Closes #309" :)

So either remove that comment (so that the issue is not automatically closed) or add the other commit here.

Also please fix the issues that @ksquirrel found.

@kloenk
Copy link
Member

kloenk commented Aug 22, 2021

maybe also relevant: #455

@ojeda
Copy link
Member

ojeda commented Oct 15, 2021

This was done in #436.

@ojeda ojeda closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

error.rs: sort and add remaining errors
5 participants