Samples #172
Merged
Samples #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganizes and splits tests into `samples/` Now that we have them split, we can remove the GitHub-only ones, too, since we have enough to test several builtins + several loadable. However, in order to keep testing the module parameters in both builtin vs. loadable and default vs. custom, we generate the modules on the fly based on the base one. Takes also the chance to update the `.config`s; as well as cleanups the unused imports in each sample now that they are split. Updates the docs accordingly too. Fixes Rust-for-Linux#65. Signed-off-by: Miguel Ojeda <[email protected]>
|
@wedsonaf This is the one you can put yours on top. |
alex
approved these changes
Apr 9, 2021
Thanks, Miguel! Do you think it would be ok to have to C counterpart in the same directory? I think it would be better if they were side by side. |
|
You're welcome! :) Yeah, just put them both there! After all, it is a C example to counter the Rust one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes and splits tests into
samples/Now that we have them split, we can remove the GitHub-only ones, too,
since we have enough to test several builtins + several loadable.
However, in order to keep testing the module parameters in both
builtin vs. loadable and default vs. custom, we generate the modules
on the fly based on the base one.
Takes also the chance to update the
.configs; as well as cleanupsthe unused imports in each sample now that they are split.
Updates the docs accordingly too.
Fixes #65.
Signed-off-by: Miguel Ojeda [email protected]