Skip to content

Add Support for Windows New Arch #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 25, 2025

Conversation

anupriya13
Copy link

@anupriya13 anupriya13 commented May 20, 2025

Summary

Adds New Architecture support for Windows to react-native-blob-util.

Screenshots

image

image

image

Testing

Tested in examples. There are some functions not working as expected maybe, but E2E working fine and most of the functions are working as expected:

testing.blob-util.mp4

image

Compatibility [react-native-blob-util]

  • Windows New Arch >= 0.22.0
  • Windows Old Arch < 0.22.0

@RonRadtke
Copy link
Owner

wow - very nice thank you!

@anupriya13 anupriya13 changed the title [Draft] Add Support for Windows New Arch Add Support for Windows New Arch May 22, 2025
@anupriya13 anupriya13 marked this pull request as ready for review May 22, 2025 10:06
@anupriya13
Copy link
Author

@RonRadtke Please review

@RonRadtke
Copy link
Owner

@RonRadtke Please review

Honestly I kinda have to rely on you all here. I currently don't have any running react-native-windows around and will need a while till I would get to. So I can sure enough do a general check on the code, but would I hope you tested it?

@anupriya13
Copy link
Author

anupriya13 commented May 23, 2025

@RonRadtke Yes, the example app launches fine, and MOST APIs are tested, in case any API doesn't work we can take that up in next PRs. Feel free to create the issue for the same.
Just one to-do in windows we don't support picker for now so removed those and added button groups instead.
I've attached testing videos to description.

@RonRadtke
Copy link
Owner

@RonRadtke Yes, the example app launches fine, and MOST APIs are tested, in case any API doesn't work we can take that up in next PRs. Feel free to create the issue for the same. Just one to-do in windows we don't support picker for now so removed those and added button groups instead. I've attached testing videos to description.

Thank you.
Old picker lib didnt work anymore regardless. Had a replacement with a newer lib ready, but buttons are completely fine thanks :)

I will go through the files once more over the weekend / on Monday and then merge it.
Unless you have some outstanding changes left?

@anupriya13
Copy link
Author

@RonRadtke Yes you can review now, I have resolved all comments.
cc: @acoates-ms

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reasons for the duplicates?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it and clean it up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants