-
Notifications
You must be signed in to change notification settings - Fork 152
Add Support for Windows New Arch #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Windows New Arch #414
Conversation
wow - very nice thank you! |
@RonRadtke Please review |
examples/ReactNativeBlobUtil/windows/packages/Microsoft.UI.Xaml.2.3.191129002/.signature.p7s
Outdated
Show resolved
Hide resolved
examples/ReactNativeBlobUtil/windows/packages/Microsoft.UI.Xaml.2.3.191129002/.nupkg.metadata
Outdated
Show resolved
Hide resolved
…/react-native-blob-util into user/anuverma/windows
windows/packages/Microsoft.Windows.CppWinRT.2.0.200615.7/.nupkg.metadata
Outdated
Show resolved
Hide resolved
Honestly I kinda have to rely on you all here. I currently don't have any running react-native-windows around and will need a while till I would get to. So I can sure enough do a general check on the code, but would I hope you tested it? |
@RonRadtke Yes, the example app launches fine, and MOST APIs are tested, in case any API doesn't work we can take that up in next PRs. Feel free to create the issue for the same. |
Thank you. I will go through the files once more over the weekend / on Monday and then merge it. |
@RonRadtke Yes you can review now, I have resolved all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reasons for the duplicates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge it and clean it up :)
Summary
Adds New Architecture support for Windows to react-native-blob-util.
Screenshots
Testing
Tested in examples. There are some functions not working as expected maybe, but E2E working fine and most of the functions are working as expected:
testing.blob-util.mp4
Compatibility [react-native-blob-util]