Scope can be configured in settings file #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, I just realized that there already is another PR for the same purpose but it adds changes on unrelated code. Looking forward to your comments! |
|
I would really love having this (or, perhaps, the other PR) merged, now that django 2 is supported this is the only thing preventing me from using this library -- my auth service relies on custom scopes heavily. The changes here seem to be pretty straight-forward and compatible with previous default behavior. Is there anything we can do to expedite merging? @kevin1024 |
|
Thanks for the nudge. Looks like a good feature. Merged. |
|
Thanks, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
These changes are useful in case someone wants to make scopes configurable by settings. For example, usually the following scopes are required for Google OAuth and right now it's not possible to make it configurable:
"https://www.googleapis.com/auth/userinfo.email""https://www.googleapis.com/auth/userinfo.profile""https://www.googleapis.com/auth/plus.me"Thanks in advance.