Skip to content

Fix segfault when no devices present and managed memory is statically declared #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from

Conversation

benrichard-amd
Copy link

Addresses ROCm/hip#3712

Fix crash that was occurring when managed memory was statically declared but no devices present.

…vices.

CLR was trying to allocate managed memory when no devices were present, resulting
in a crash.
rahulc-gh pushed a commit that referenced this pull request May 15, 2025
Change-Id: I6a3783beafdbb9f11a3b37333f4ff3f5be27ea54
@BenWibking
Copy link

I reported this bug 6 months ago. Is there anything holding up this PR?

Copy link
Contributor

@saleelk saleelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saleelk
Copy link
Contributor

saleelk commented Jun 3, 2025

Thanks for the change, I apologize somehow we missed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants