Skip to content

Special-case object alias _typeshed.Unused #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2023
Merged

Special-case object alias _typeshed.Unused #320

merged 4 commits into from
Jan 14, 2023

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jan 14, 2023

@Avasam
Copy link
Contributor Author

Avasam commented Jan 14, 2023 •
edited
Loading

Originally this was meant just for Y036. But I figured since it's an alias, it'd work with the same logic everywhere it's checking for an object. No chance of falling out of sync with other checks.

Should I update more tests? Make a specific alias test?

@Avasam
Copy link
Contributor Author

Avasam commented Jan 14, 2023

typeshed primer comment error: https://github.com/PyCQA/flake8-pyi/actions/runs/3919162265/jobs/6699991358 Not sure if it's just a random failure (BAD GATEWAY sounds on Github's side). Been having lot of random CI failure lately.

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basic idea's good, but here's a few nits ;)

@Avasam Avasam requested a review from AlexWaygood January 14, 2023 16:06
@github-actions
Copy link

This change has no effect on typeshed. 🤖🎉

AlexWaygood
AlexWaygood approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@AlexWaygood AlexWaygood merged commit fbdc4e0 into PyCQA:master Jan 14, 2023
@Avasam Avasam deleted the special-case-typeshed-unused branch January 14, 2023 16:10
@AlexWaygood
Copy link
Collaborator

Been having lot of random CI failure lately.

If you're talking about the "flukes" over at typeshed, I'm afraid they're probably not just flukes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avasam @AlexWaygood