Skip to content

Add first draft of CODEOWNERS file #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add first draft of CODEOWNERS file #23

merged 1 commit into from
Jan 14, 2021

Conversation

kmpaul
Copy link
Collaborator

@kmpaul kmpaul commented Jan 14, 2021

The GitHub usernames listed in this file will be triggered automatically for review.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 14, 2021

If you want someone's name listed as a code owner in this file, please let me know.

@jukent
Copy link
Contributor

jukent commented Jan 14, 2021

Looks good. Just to clarify this would automatically request reviews from everyone listed?
Currently if I left a review on this PR it "wouldn't count towards merge-ability" without my review being explicitly requested.

@brian-rose
Copy link
Member

This looks great.

Presumably other reviewers can/will still be added manually as appropriate for each PR.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 14, 2021

@jukent: Yes. The rule is, if anything is changed in the ci/ directory, then @andersy005 and I get pinged for review. If anything in the content/ directory changes, then you and I get pinged for review. If anything else changes (i.e., only in the / root directory), then only I get pinged for review.

@brian-rose: Yeah. We can always add more people later.

@dopplershift
Copy link
Contributor

@kmpaul If you're going to be listed as global, it's not really serving any purpose to have you listed on the directories too. It's also not hurting anything, though.

Probably should give @jukent write-access to the repo if she's listed as in CODEOWNERS.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 14, 2021

@dopplershift: I thought that the "global" owner category was for "anything that didn't meet other criteria". I didn't think that I would be asked for review on changes in content/ unless I was explicitly added to that pattern.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 14, 2021

(Also, @jukent, @dcamron, and @andersy005 should all have write access, now.)

@jukent
Copy link
Contributor

jukent commented Jan 14, 2021

(Also, @jukent, @dcamron, and @andersy005 should all have write access, now.)

Can confirm.

@dopplershift
Copy link
Contributor

@kmpaul You're right it seems and I have learned something today. 😉

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jan 14, 2021

Ok. I'm going to merge.

@kmpaul kmpaul merged commit bb46544 into ProjectPythia:main Jan 14, 2021
@kmpaul kmpaul deleted the codeowners branch January 14, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants