Skip to content

Add Google Analytics block back to landing page #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Add Google Analytics block back to landing page #120

merged 1 commit into from
Jun 22, 2021

Conversation

kmpaul
Copy link
Collaborator

@kmpaul kmpaul commented Jun 22, 2021

closes #114

@kmpaul kmpaul requested a review from a team as a code owner June 22, 2021 17:38
@kmpaul kmpaul requested review from dopplershift and jukent June 22, 2021 17:38
@kmpaul kmpaul mentioned this pull request Jun 22, 2021
Closed
@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 22, 2021

I don't know why the RTD check says it is still pending. It is complete and you can follow the link to the docs.

@brian-rose
Copy link
Member

I've found this several times over the past couple of weeks. Resyncing the webhook seems to cure the problem, at least for a while.

@jukent
Copy link
Contributor

jukent commented Jun 22, 2021

Kevin can you explain this a little bit? I don't see where the Google analytics are on the landing page.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 22, 2021

@jukent: I haven't added you to the Google Analytics account, but if you want to be added, I can add you. You will be sent an email with information about how to log in.

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 22, 2021

@jukent: Also, Google Analytics just tracks who visits the site. The data is held on the Google Analytics site, not on the landing page.

@jukent @andersy005 @dcamron I've added you all to the Google Analytics account, too.

jukent
jukent approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Right now our average engagement time is a single minute! Maybe we can get that up haha

@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 22, 2021

Should I just merge this? I have 1 or 2 required approvals and the website doesn't break due to this change.

@kmpaul kmpaul merged commit e229e45 into ProjectPythia:main Jun 22, 2021
@kmpaul
Copy link
Collaborator Author

kmpaul commented Jun 22, 2021

Thanks, @brian-rose!

@kmpaul kmpaul deleted the fix-analytics branch June 22, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-rose brian-rose brian-rose approved these changes

@jukent jukent jukent approved these changes

@dopplershift dopplershift Awaiting requested review from dopplershift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page visit metrics
3 participants
@kmpaul @brian-rose @jukent