-
Notifications
You must be signed in to change notification settings - Fork 45
Revamped Book and User Collections #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mohitmadhav It is working on my device. did you add this ISBN no: 9780062416216? |
Mine is: 9788172234980 |
See the discussions. |
Notify once you are done @keyurgit45 |
I'm done. I made PR 2 hrs ago. I thought you will get notified 😅 |
Why is it different for the 2 branches? In main earlier I had 2 books saved but not in your branch. Why is that any idea? |
No worries @keyurgit45 , that was some cache error, will look into it later. |
Actually, I didn't change anything other than add_book button's code. What are we basically doing is The same book is being added in users and books collection under owned books so when we are fetching data in the Library page we are taking from users collection not from books. That's the basic idea. @Mohitmadhav |
Yeah got it. |
Description
Revamped books and user collection. added given fields. earlier add book button was not working. Fixed add book button functionality. Now when a user adds a book, it gets added in both users and books collections under owned books. (as per discussion)
Summary of the changes and which issue is fixed.
Fixes #92
Type of change
Checklist: