Skip to content

Add key binding for Show Additional Commands #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2018

Conversation

dsolodow
Copy link
Contributor

Adds default keyboard shortcut Ctrl-Alt-A for "Show Additional Commands from Modules".
Resolves #196

Adds default keyboard shortcut Ctrl-Alt-A for "Show Additional Commands from Modules".
@TylerLeonhardt
Copy link
Member

I think we're not supposed to be using Ctrl+Alt key combinations in VS Code since they can conflict with Windows shortcuts.

Do you see any kind of errors in the Developer Tools console (Ctrl+Shift+I, check the Console tab) complaining about this shortcut?

I believe any other modifier combination is ok: Ctrl-Shift, Alt+Shift. It's easy to test at least.

Avoid using Ctrl-Alt combo as these can be problematic
@dsolodow
Copy link
Contributor Author

Modified PR with new binding to avoid Ctrl-Alt

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Looks like an unused keybinding. LGTM!

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

Thanks for this, @dsolodow!!

@TylerLeonhardt TylerLeonhardt merged commit a838cf5 into PowerShell:master Mar 22, 2018
@rjmholt
Copy link
Contributor

rjmholt commented Apr 25, 2018

Just to document: the final keybinding here was Shift-Alt-S.

@dsolodow dsolodow deleted the patch-1 branch January 12, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants