OpenSSHUtils Module Not Handling Localization of User IDs for German

[DarwinJS]

A user reported the below error with the Chocolatey Package - but this is actually coming from the OpenSSHUtils module.

Here is the full Chocolatey verbose log (which reveals many other details about the user's target system) that contains the below error near the bottom: https://gist.githubusercontent.com/Waterdrop0815/39325828f4fc39595fce9304f1a98fda/raw/3de27c0e9700b9b9ae89a9ede94c0fa4ab1f15f4/choco-log.txt

It seems like 'NT-AUTORITÄT\SYSTEM' might be the localized version of 'NT AUTHORITY\SYSTEM'.

Perhaps the script should be changed to only use well known SIDS (e.g. on lines 2,3 and 5) and then translate to text user ids on the target systems if and when necessary. Maybe the string "NT SERVICE" needs localization as well?

2017-06-16 18:28:57,008 5784 [INFO ] -   [*] C:\Program Files\OpenSSH-Win64\sshd_config
2017-06-16 18:28:57,462 5784 [INFO ] - 'NT AUTHORITY\SYSTEM' now owns 'C:\Program Files\OpenSSH-Win64\sshd_config'. 
2017-06-16 18:28:57,837 5784 [INFO ] - 'NT-AUTORITÄT\SYSTEM' has no more access to 'C:\Program Files\OpenSSH-Win64\sshd_config'.
2017-06-16 18:28:58,095 5784 [INFO ] - 'VORDEFINIERT\Administratoren' has no more access to 'C:\Program Files\OpenSSH-Win64\sshd_config'.
2017-06-16 18:28:58,339 5784 [INFO ] - 'VORDEFINIERT\Benutzer' has no more access to 'C:\Program Files\OpenSSH-Win64\sshd_config'.
2017-06-16 18:28:59,009 5784 [ERROR] - ERROR: Exception calling "RemoveAccessRule" with "1" argument(s): "Some or all identity references could not be translated."
2017-06-16 18:28:59,369 5784 [DEBUG] - Built-in PowerShell host called with ['[System.Threading.Thread]::CurrentThread.CurrentCulture = '';[System.Threading.Thread]::CurrentThread.CurrentUICulture = ''; & import-module -name 'C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1'; & 'C:\ProgramData\chocolatey\helpers\chocolateyScriptRunner.ps1' -packageScript 'C:\ProgramData\chocolatey\lib\openssh\tools\chocolateyinstall.ps1' -installArguments '' -packageParameters '/SSHServerFeature SSHAgentFeature SSHServerPort:13337''] exited with '-1'.
2017-06-16 18:28:59,431 5784 [DEBUG] - Calling command ['"C:\WINDOWS\System32\shutdown.exe" /a']
2017-06-16 18:28:59,603 5784 [DEBUG] - Command ['"C:\WINDOWS\System32\shutdown.exe" /a'] exited with '1116'````

[manojampalam]

@bingbing8 this may be an issue in code too that does SID lookups based on account names and account name comparisons. Please follow up.

[philSixZero]

Had the same issue (since I am using a german WIN7 Version as well), but I could fix it by modifying line

$systemAccount = New-Object System.Security.Principal.NTAccount("NT AUTHORITY", "SYSTEM")

to

$systemAccount = New-Object System.Security.Principal.NTAccount("NT-AUTORITÄT", "SYSTEM")

in OpenSSHUtils.psm1. So I guess, you only have to check the language version which is used, to fix this bug.

[megamorf]

It'd be better to just translate the SID to the locale of the system that the function is being run on.

See here: https://technet.microsoft.com/en-us/library/ff730940.aspx

[DarwinJS]

@megamorf - yes that is what I suggested in the original issue and I believe @bingbing8 has already worked out the code.

[bagajjal]

@philSixZero - for the first time failure (launching powershell from a different path), what did you set in the sshd_config (is it the full path of powershell.exe you would like to launch)? please share you sshd_config for both the cases.

since this is not related to the localization issue, could you please raise a new issue so that the bug is tracked and properly fixed.

[bingbing8]

script is fixed. please re-open if you see other issues.