Skip to content

Refactor Analysis code #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rjmholt opened this issue Apr 23, 2018 · 1 comment
Closed

Refactor Analysis code #657

rjmholt opened this issue Apr 23, 2018 · 1 comment
Assignees
@rjmholt
Labels
Area-General

Comments

@rjmholt
Copy link
Contributor

rjmholt commented Apr 23, 2018 •
edited
Loading

The PSES analysis code has grown a bit and recent forays into it indicate it might be due for a clean up. The script analysis part of PSES is one of its main jobs and where a lot of performance issues seem to lie. We should refactor the code here as much as possible to simplify how analysis works, do as little work as required, and ideally not call PowerShell unless we really need to.
@rjmholt
Copy link
Contributor Author

rjmholt commented May 1, 2018

Looks like I should do this anyway since I need to fix PowerShell/vscode-powershell#1298.

@rjmholt rjmholt self-assigned this May 1, 2018
@rjmholt rjmholt mentioned this issue Jun 5, 2018
Merged
@rjmholt rjmholt closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjmholt rjmholt

Labels
Area-General
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerLeonhardt @rjmholt