-
Notifications
You must be signed in to change notification settings - Fork 236
Add go to definition support for dot sourced file paths #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is definitely a good idea, will add it for 0.2. |
I'd like to start working on this. I won't be very quick, but seeing as it has been untouched for over 2 years that should not be a big problem. I have a question about the desired behavior. It's simple if the dot sourced script is a full path, however let's assume that we have |
I think that's the correct approach. There will be some scenarios where we will be unable to find the file like in this example: If |
So full paths and paths that resolve correctly from the current location PSES is at is probably good enough for now - and I think a lot of folks would be happy to see this! |
We should be able to at least handle |
Alright sounds good, thanks. I'll give it a go. |
Fix language id
When peek definition or go to definition are used on a dot sourced file nothing happens. This is currently the same behavior that happens on built-in commands where the source file can't be found.
Should peek and go to definition bring the user to the very beginning of the dot sourced file when those features are used?
The text was updated successfully, but these errors were encountered: