Warn when an if statement contains an assignment#859

Merged

JamesWTruher merged 7 commits intoPowerShell:developmentfrom

bergmeister:warnWhenUsingAssignmentInsideIfStatement

Feb 5, 2018

Commits on Jan 28, 2018

first try at implementation rule. basically works but also catches case where the execution block of the if statement contains an assignment
bergmeister
committed
remove unused variables and fix test to import pssa and fix some rule counter tests
bergmeister
committed

Commits on Feb 1, 2018

Improve rule to only assert against clause in if statement. TODO: Make sure that the following case does not get flagged up (added a test case for it) 'if ( $files = get-childitem ) { }'
bergmeister
committed
Improve rule to reduce false warnings and adds lots more tests. The only false positive that is left is 'if ($a = (Get-ChildItem)){}' where the RHS is wrapped in an exprssion
bergmeister
committed

Commits on Feb 3, 2018