Add CustomRulePath property to settings file #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 20, 2017 14:04
| private bool OverrideSwitchParam(bool paramValue, string paramName) | ||
| { | ||
| return MyInvocation.BoundParameters.ContainsKey(paramName) | ||
| ? ((SwitchParameter)MyInvocation.BoundParameters[paramName]).ToBool() |
There was a problem hiding this comment.
what if this is false..do you want to use the original value
There was a problem hiding this comment.
The idea is that if the user doesn't specify a switch, then use the value from the settings file. But if the user specifies the switch on the command line then use the command line argument.
For example, if IncludeDefaultRules is set to $true in the settings file and if the user specifies -IncludeDefaultRules:$false on the command line, then the final value for IncludeDefaultRules will be set to $false
|
LGTM |
|
@KrishnaV-MSFT Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.