Skip to content

Broken link to list of approved verbs #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Broken link to list of approved verbs #1734

wants to merge 1 commit into from

Conversation

antoniouaa
Copy link

The link was missing part of the URL that redirected to the MS docs.
From

/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands

to

https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands

PR Summary

Fixes a broken link that 404's on GitHub but should direct to MS doc for Approved Verbs

PR Checklist

The link was missing part of the URL that redirected to the MS docs.
From
```
/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands
```
to
```
https://docs.microsoft.com/en-us/powershell/scripting/developer/cmdlet/approved-verbs-for-windows-powershell-commands
```
@sdwheeler
Copy link
Collaborator

@andschwa The link is correct for the docs platform. It will be broken on GitHub but it is correct when published to the website. Please do not merge this PR.

See our contributor guide for more information: https://docs.microsoft.com/powershell/scripting/community/contributing/powershell-style-guide#hyperlinks

Copy link
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge this change.

@rjmholt
Copy link
Contributor

rjmholt commented Oct 26, 2021

@JamesWTruher @bergmeister we should discuss how we handle this issue in general

@antoniouaa
Copy link
Author

Maybe you should add an alternative link then? This was my first stop when searching for a list of approved verbs and it probably is for a lot of other people.

@sdwheeler
Copy link
Collaborator

This is source code, not documentation. You should be looking at the docs.microsoft.com site for documentation.

@andyleejordan
Copy link
Member

I think people are still going to look at the GitHub repo for documentation too, especially since that's where it's been hosted for years.

@bergmeister
Copy link
Collaborator

Closing since PR #1738 superseded it. Please shout if that is not correct.

@antoniouaa antoniouaa deleted the patch-1 branch March 31, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants