Upgradable modules #553
Merged
Upgradable modules #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamakgec
previously requested changes
Feb 18, 2019
maxsam4
reviewed
Feb 18, 2019
maxsam4
reviewed
Feb 18, 2019
maxsam4
approved these changes
Feb 19, 2019
# Conflicts: # contracts/libraries/TokenLib.sol # contracts/modules/Experimental/Mixed/ScheduledCheckpoint.sol # contracts/modules/Experimental/Wallet/VestingEscrowWallet.sol # contracts/modules/TransferManager/TransferManager.sol # contracts/proxy/CountTransferManagerProxy.sol # contracts/proxy/ERC20DividendCheckpointProxy.sol # contracts/proxy/EtherDividendCheckpointProxy.sol # contracts/proxy/GeneralTransferManagerProxy.sol # contracts/proxy/ManualApprovalTransferManagerProxy.sol # contracts/proxy/PercentageTransferManagerProxy.sol # contracts/proxy/USDTieredSTOProxy.sol # contracts/proxy/VestingEscrowWalletProxy.sol # contracts/proxy/VolumeRestrictionTMProxy.sol # contracts/tokens/SecurityToken.sol # test/d_count_transfer_manager.js
Permission cleanup
Remove the investor array and add isVolRestricted flag for investors
Refactor takeSnapShot
…okenData Add version to `getSecurityTokenData` (referenced directly from token using getVersion)
satyamakgec
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up interface vs. implementation using public getters in module factories.
Add UpgradableModuleFactory and use it consistently across upgradable modules.
Allow in-place upgrading of modules by token issuers.
Disallow changing of module types
Add fixed usage fees in POLY
Remove module instructions
Treat versions consistently in proxy based modules
Refactor module deployment to use base class code
Some refactoring of modifiers to internal functions
Clean up duplicated events in Security Token
Make LockUpTM upgradable (proxy deployment)
Allow all proxy based modules to be upgradable