Skip to content

Stable oracle #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Stable oracle #546

merged 4 commits into from
Feb 11, 2019

Conversation

adamdossa
Copy link
Contributor

@adamdossa adamdossa commented Feb 7, 2019

Adds a "StableOracle" which only updates it's price if the latestPrice is more than x% (configurable) from the last served price. This allows USD > POLY conversions which are less likely to change and an improved UX for this feature.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.9% when pulling 42ae425 on stable-oracle into c87ebf9 on dev-3.0.0.

Copy link
Contributor

@maxsam4 maxsam4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamdossa adamdossa merged commit 45933ee into dev-3.0.0 Feb 11, 2019
@satyamakgec satyamakgec deleted the stable-oracle branch October 30, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants