Skip to content

Adding Circle CI to master #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 17, 2018
Merged

Adding Circle CI to master #471

merged 26 commits into from
Dec 17, 2018

Conversation

maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Dec 14, 2018

TODO

  1. Enable CircleCI
  2. Set coveralls repo token in CircleCI environment
  3. Set Github login username and password in CircleCI environment for pushing docs
  4. Disable PR builds in Travis as coverage is now handled by CircleCI

Main changes in the CI workflow:

  1. Travis is used for tests
  2. CircleCI is used for coverage and docs
  3. Docs are only generated when a commit is pushed to master branch
  4. Coverage is now generated for every commit rather than only PR commits

I have also configured our test script to support parallelism offered by CircleCI. i.e, if in future we move tests to CircleCI from Travis, we will be able to split tests into X simultaneous parts for faster execution. Timing data of various configs available on Asana.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants