Represent most nullable ptrs as Option<*T>s in the ffi
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzab
added a commit
that referenced
this pull request
Nov 28, 2013
Represent most nullable ptrs as `Option<*T>`s in the ffi
|
This change is giving me some issues. I'm no longer able to create an opengl window with my own code or with your examples. I'm guessing it is the fallout of rust-lang/rust#10571 and rust-lang/rust#10570. With the current version of rust (90d06ec) reports the sizeof |
|
Weird. Sorry about that, I will revert it. I was hoping that using Options where the pointers were nullable would better convey the semantics, but it seems like we cannot rely on this behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.