Skip to content

fix userauth_publickey_frommemory throw TypeError #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix userauth_publickey_frommemory throw TypeError #75

wants to merge 1 commit into from

Conversation

xjkuchao
Copy link

default publickeyfiledata is None, will throw TypeError: object of type 'NoneType' has no len() when use userauth_publickey_frommemory

@xjkuchao
default publickeyfiledata is None, will throw TypeError: object of ty…
e0e6c64 
…pe 'NoneType' has no len() when use userauth_publickey_frommemory
pkittenis
pkittenis requested changes May 9, 2019
View reviewed changes
Copy link
Member

@pkittenis pkittenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please:

  • Re-generate the C file for session - install cython or use pip install -r requirements_dev.txt followed by a build
  • Make a short test for this function - see existing userauth_* function tests

@pkittenis
Copy link
Member

Done by #104

@pkittenis pkittenis closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkittenis pkittenis pkittenis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjkuchao @pkittenis