Need to use octal to get the correct permissions #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
& with the int 777 rather than the octal 0o777 changes the perms on the remote file to be wrong. For me it set everything to 400 rather than 644.
|
Looked at the failures and it seems to be an auth issue in the build job (at least from what I could see on the surface). Don't think updating an example could cause many actual issues. I'm happy to help how I can though |
|
Hi there, Thanks for the interest and PR! Yes, good spot, had actually fixed same issue in The failures are from the docker scripts trying to push to the docker repo, which PR branches do not have access to. I'll raise a separate issue to resolve that for future PRs. Looks good, thanks. |
Red-M
pushed a commit
to Red-M/ssh2-python
that referenced
this pull request
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& with the int 777 rather than the oct 0o777 changes the perms on the remote file to be wrong. For me it set everything to 400 rather than 644.