ssh2.session.Session.userauth_publickey_frommemory() - TypeError: object of type 'NoneType' has no len()

[PhenomPBG]

host = "127.0.0.1"
port = 22
user_name = "user"
privatekey_data = "..."
passphrase = ""

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.connect((host, port))
session = Session()
session.handshake(s)

session.userauth_publickey_frommemory(user_name, privatekey_data.encode('ascii'), passphrase=passphrase)

Last line from stack trace:

File "ssh2/session.pyx", line 240, in ssh2.session.Session.userauth_publickey_frommemory
TypeError: object of type 'NoneType' has no len()

Seems like the optional argument publickeyfiledata defaults to None, but its len() is always checked anyway.

Tested on both 0.17 and 0.18 with Python 3.7.1 on CentOS 7.

[PhenomPBG]

Cleaned up the sample code a bit.

[j3pic]

@PhenomPBG the bug remains. #90 doesn't fix it either. I've made a new PR that should fix it.

[PhenomPBG]

@PhenomPBG the bug remains. #90 doesn't fix it either. I've made a new PR that should fix it.

Thanks!

[j3pic]

@Red-M Will your fork become the version of ssh2-python that installs from PyPI?

[j3pic]

There's another problem with my patch: It doesn't compile under Python 3.7 and higher because the C source files were built with the wrong version of Cython (but if I upgrade and generate the C files again, they'll be incompatible with Python 3.6 and below.

[j3pic]

@Red-M Reading the code for #90 it looks like this bug should be fixed there. I'm not sure why I still saw it when I tested manually. Probably because of the bug in Pip I found that affects the use of Git repos from requirements.txt. There's a nonzero chance I was still running the version of ssh2-python from PyPI.

[basegodfelix]

still experiencing this issue.

On a side note, if I use the same key and auth from file, it works. Same error thrown as above poster:

File "ssh2/session.pyx", line 237, in ssh2.session.Session.userauth_publickey_frommemory
TypeError: object of type 'NoneType' has no len()

Private key provided

[kdart]

A workaround that seems to work for me is to set the publickeyfiledata to an empty bytestring (b'').