session.forward_listen_ex bound_port access

[caryfitzhugh]

When calling forward_listen_ex the third parameter is "bound_port" which is passed by reference in the pyx file to libssh2

With python not having pointers to int values, how would one get access to that resulting port value?

I have tried

session.forward_listen_ex('localhost', 0 , bound_port, 10)

And the forward is created, but bound_port is not updated.

I could add a PR for a forward_listen_ex2 which returns the tuple of the port and Listener? Or is there a way to do this?

[pkittenis]

Hi there,

Thanks for the interest and report. Yes, it looks like that function should return port as well in a tuple and not take bound_port as argument.

PR is welcome. Can change the existing function, don't make a new one please. Changing the API while in 0.x.y version is ok.

[caryfitzhugh]

Hello @pkittenis - that sounds fine.

The modifications to the .pyx file went smoothly, but building things again - what are the instructions?
I am using cython 0.29.5 as well.

I am trying the following to test locally, but seems I am missing something.

rm -rf ./ssh2/*.c
export EMBEDDED_LIB=1; export HAVE_AGENT_FWD=1; python2 setup.py build
rm -rf ./src
pip install .

[pkittenis]

There are instructions on the contribution guide. Broadly:

pip install -r requirements_dev.txt
python setup.py build_ext -i

Best not to change env variables from their defaults unless sure what that means - particularly HAVE_AGENT_FWD.

build needs a separate install for the code to apply. The above installs modules in-place. Modified pyx files cause automatic C file re-generation, no manual steps needed. There are cases where the rest of the C code needs re-generating though, like when definitions in the pxd files are changed.

[caryfitzhugh]

Here's my first attempt at making this work. @pkittenis