This repository was archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
onUpdateStatus gets called with bad params #8
Comments
hi Tomas, |
Hello Sebastien, I am not sure what do you need. The problem is in media.ts:204, as I wrote and it is about two different types being sent to that event handler. One time it is string (EnumMediaStatus), other time object (PlaybackStatus). It should always be the PlaybackStatus object. Regards, Tomas |
This was referenced Jul 19, 2018
Closed
Closed
Merged
sebdurand
added a commit
that referenced
this issue
Jul 19, 2018
* fix rollup export interface @see rollup/rollup-plugin-typescript#28 * fix attach/detach listeners after load/clear * fix return id tracks not implemented * fix attach/detach listeners after load/clear * fix return id tracks not implemented * Update package.json * Update package.json * add skip_cleanup: true / deploy / npm
sebdurand
added a commit
that referenced
this issue
Jul 19, 2018
* 1.0.3 (#3) * refactoring : playbackstatus as int * fix reply connection status * fix getMetadata * fix tracks * fix format code * 1.0.4 (#12) * refactoring : playbackstatus as int * fix reply connection status * fix getMetadata * fix tracks * fix format code * Fix playback status, connection status, metadata and tracks support. * refactoring : playbackstatus as int * fix reply connection status * fix getMetadata * fix tracks * fix format code * fix npmjs deploy * fix npm deploy * fixes #6 #7 #8 #9 #13 (#18) * fix rollup export interface @see rollup/rollup-plugin-typescript#28 * fix attach/detach listeners after load/clear * fix return id tracks not implemented * fix attach/detach listeners after load/clear * fix return id tracks not implemented * add skip_cleanup: true / deploy / npm * update protocol * fix handle propertly transmission errors
juliendelage
added a commit
that referenced
this issue
Jul 26, 2018
fix: Correction on "onupdatestatus" #8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The onUpdateStatus of IMediaNotifier interface...
...should be called with first argument as PlaybackStatus described like this:
Sometimes it gets the EnumMediaStatus instead:
It happens here (media.ts:204):
Thank you,
Tomas
The text was updated successfully, but these errors were encountered: