Skip to content

Removal of 'deprecated' not detected #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michael-schnell opened this issue Mar 3, 2023 · 2 comments · Fixed by #743
Closed

Removal of 'deprecated' not detected #485

michael-schnell opened this issue Mar 3, 2023 · 2 comments · Fixed by #743
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification help wanted
Milestone
2.1.0

Comments

@michael-schnell
Copy link

Removal of 'deprecated' is not detected iny any section (headers, operation,parameter, schema).

V1

headers:
    X-RateLimit-Limit:
      schema:
          type: integer
      deprecated: true

V2 (removal of 'deprecated')

headers:
    X-RateLimit-Limit:
      schema:
          type: integer

A new 'deprecated' is detected everywhere, but removal not.
@joschi
Copy link
Contributor

joschi commented Mar 4, 2023

@michael-schnell Thanks for reporting this!

Would you expect removing of the deprecation to be a breaking change or a mere informational message/compatible change?

@michael-schnell
Copy link
Author

I think it's compatible. This change is only of interest for documentation purposes where you will state something like "X-RateLimit-Limit is no longer deprecated since version 1.2.3".

@DrSatyr DrSatyr added bug and removed bug labels Jan 30, 2025
@DrSatyr DrSatyr self-assigned this Jan 30, 2025
@DrSatyr DrSatyr added this to the 2.1.0 milestone Jan 30, 2025
DrSatyr added a commit that referenced this issue Feb 6, 2025
@DrSatyr
Add test case for issue #485, group all SchemaDiff related test cases…
bd47305 
… under one test class.
@DrSatyr DrSatyr mentioned this issue Feb 7, 2025
Merged
DrSatyr added a commit that referenced this issue Feb 11, 2025
@DrSatyr
Removal of 'deprecated' not detected (#743)
3afafef 
* Fix issue #485 - Removal of 'deprecated' is not detected on schema, operation, parameter, and header level.
* Reorganize tests structure
* Extend test coverage for CchemaDiff, OperationDiff, ParameterDiff, HeaderDiff
@DrSatyr DrSatyr linked a pull request Feb 11, 2025 that will close this issue
Removal of 'deprecated' not detected #743
Merged
@DrSatyr DrSatyr closed this as completed Feb 11, 2025
@DrSatyr DrSatyr added the Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification label Apr 5, 2025
@DrSatyr DrSatyr removed their assignment Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification help wanted
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Removal of 'deprecated' not detected OpenAPITools/openapi-diff
3 participants
@joschi @michael-schnell @DrSatyr