Skip to content

missing execution field in pom.xml in release 1.2.0 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghostbody opened this issue Dec 26, 2019 · 1 comment · Fixed by #159
Closed

missing execution field in pom.xml in release 1.2.0 #114

ghostbody opened this issue Dec 26, 2019 · 1 comment · Fixed by #159
Labels
Milestone

Comments

@ghostbody
Copy link

execution field is missing in pom.xml in release 1.2.0 and the with-dependency jar is missing in the target.

             <plugin>                                                                                                                                                   
                 <artifactId>maven-assembly-plugin</artifactId>                                                                                                         
                 <configuration>                                                                                                                                        
                     <archive>                                                                                                                                          
                         <manifest>                                                                                                                                     
                             <mainClass>com.qdesrame.openapi.diff.Main</mainClass>                                                                                      
                         </manifest>                                                                                                                                    
                     </archive>                                                                                                                                         
                     <descriptorRefs>                                                                                                                                   
                         <descriptorRef>jar-with-dependencies</descriptorRef>                                                                                           
                     </descriptorRefs>                                                                                                                                  
                 </configuration>                                                                                                                                       
                 <!--- missing execution here -->                                                                                           
             </plugin> 
            <plugin>                                                                                                                                                   
                 <artifactId>maven-assembly-plugin</artifactId>                                                                                                         
                 <configuration>                                                                                                                                        
                     <archive>                                                                                                                                          
                         <manifest>                                                                                                                                     
                             <mainClass>com.qdesrame.openapi.diff.Main</mainClass>                                                                                      
                         </manifest>                                                                                                                                    
                     </archive>                                                                                                                                         
                     <descriptorRefs>                                                                                                                                   
                         <descriptorRef>jar-with-dependencies</descriptorRef>                                                                                           
                     </descriptorRefs>                                                                                                                                  
                 </configuration>                                                                                                                                       
                 <executions>                                                                                                                                           
                     <execution>                                                                                                                                        
                         <id>make-assembly</id>                                                                                                                         
                         <phase>package</phase>                                                                                                                         
                         <goals>                                                                                                                                        
                             <goal>single</goal>                                                                                                                        
                         </goals>                                                                                                                                       
                     </execution>                                                                                                                                       
                 </executions>                                                                                                                                          
             </plugin>                                                                                                                                                  
         </plugins> 
joschi added a commit to joschi/openapi-diff that referenced this issue Jun 22, 2020
* Don't run unnecessary build steps when building the Docker image
* Always build JAR with dependencies when building the CLI module (refs OpenAPITools#114)
@joschi
Copy link
Contributor

joschi commented Oct 22, 2020

This has been resolved in #159.

@joschi joschi closed this as completed Oct 22, 2020
@joschi joschi linked a pull request Oct 22, 2020 that will close this issue
@joschi joschi added the bug label Oct 22, 2020
@joschi joschi added this to the Release 2.0.0 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants