fix(badges): Fix bug when notification has badge set to zero #1565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add additional flag to
OSNotification
calledhasBadge
to let us differentiate between null vs 0 badge count by checking this flag.Details
Motivation
notification.badge
could not differentiate null vs 0, and we detected 0 as lack of existence.Click to see the before and after clips
set_to_zero_badge_before.mov
set_to_zero_after.mov
Scope
Adds additional boolean property to OSNotification, leaving previous
badge
property unchanged.Testing
Unit testing
None
Manual testing
iphone 13 on iOS 18.5 testing different notifications sent with
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is