-
Notifications
You must be signed in to change notification settings - Fork 161
Introduce SELinux policy module for kiwi #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
90fb2dc
to
7d6a1b0
Compare
This simple policy module ensures that the kiwi executable is labeled such that it works properly in SELinux enforcing mode.
7d6a1b0
to
c5c0cc8
Compare
This is a fuller alternative to #2757 that lets us easily add more things in the future. |
Really nice, thanks for this work 👍 I'm pretty dumb regarding selinux policies. Would be great if we get some reviewer with knowledge in that area. Otherwise I'm perfectly fine adding it the way you did it because I believe you tested it to work :) |
question: why add this as separate module here instead of in the fedora policy that is used by almost everyone? usually this only makes sense when the maintainers of the project are well-versed in selinux and can maintain this module long-term, otherwise you will run into more issues also it is a bit odd that the module is reusing an existing type, usually modules define their own types and rules around their type also: what exactly is breaking? |
Well, I am well-versed in SELinux. I've done a fair bit of SELinux policy work over the years in both Fedora and openSUSE. And as a team, we do need to develop more skill with SELinux anyway, since not knowing how to deal with it is bad for us as an image build tool. But there are two big reasons:
This does not preclude contributing it into fedora-selinux, and that will probably happen down the road as this is firmed up.
Yes, I will probably change to this approach, but I need to spend more time to write it. |
There have been requests from Fedora and CentOS to make kiwi work properly in SELinux enforcing mode as all the legacy image build tools in Fedora already do. After soliciting some advice from the OSBuild folks, I had identified an approach to resolve that problem. It also neatly resolves a problem nobody has yet noticed in openSUSE, in which you cannot build an image in SELinux enforcing mode. |
This simple policy module ensures that the kiwi executable is labeled such that it works properly in SELinux enforcing mode.