feat: table header rendering optimization #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #628
Simple tables always show the first row with header styling (background color), regardless of whether header settings are enabled. This is inconsistent with Notion's native behavior.
This PR fixes table header rendering to only apply styling when explicitly enabled:
table_block_column_headeris truetable_block_row_headeris trueNote: There's an interesting naming confusion in Notion's API - table_block_column_header actually controls row headers, while table_block_row_header controls column headers. This PR maintains the original field names for API compatibility but implements the correct behavior.
After
Notion Test Page ID
1eb1578febe58070a07edf70bd34025d