Skip to content

fix for ns7 (new app structure) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

weathered-fire-2600
Copy link
Contributor

Referes to #72

Please not that this is major update and not backward compatible with ns6 due to different app structure. Users building ns6 based apps should use v2.0.0 of this plugin.

Currently there is a fix pending for nativescript-hook and I used the feature branch from @NathanWalker

Also one must use the fixed appsync-cli version, see https://github.com/Puracy/nativescript-app-sync-sdk-cli (pull request pending). With this fix you can build and release ns7 based apps to appsync server.

@cla-bot
Copy link

cla-bot bot commented Jan 12, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @weathered-fire-2600.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@weathered-fire-2600
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 12, 2021

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label Jan 12, 2021
@wendt88
Copy link

wendt88 commented Jan 27, 2021

@EddyVerbruggen can you please merge it?
@weathered-fire-2600 thx!

@sivo1981
Copy link

Any chance this will get merged soon?

@cla-bot
Copy link

cla-bot bot commented Feb 17, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @weathered-fire-2600.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot cla-bot bot removed the cla: yes label Feb 17, 2023
@NathanWalker NathanWalker merged commit d612c5c into NativeScript:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants