This repository was archived by the owner on Jan 19, 2025. It is now read-only.
Sredneva Anastasiya. Lab 1. Var 3. #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ly4
suggested changes
Mar 31, 2024
m-ly4
suggested changes
Apr 1, 2024
| bool ParseArgs(const CompilerInstance &CI, | ||
| const std::vector<std::string> &args) override { | ||
| for (const auto &arg : args) { | ||
| if (arg == "-error") { |
There was a problem hiding this comment.
Could you please add a test with this option specified?
m-ly4
approved these changes
May 7, 2024
Comment on lines
17
to
27
| if (isWarning) { | ||
| diagnID = diagn.getCustomDiagID(DiagnosticsEngine::Warning, | ||
| "The function name has 'deprecated'"); | ||
| diagn.Report(fDecl->getLocation(), diagnID) | ||
| << fDecl->getNameInfo().getAsString(); | ||
| } else { | ||
| diagnID = diagn.getCustomDiagID(DiagnosticsEngine::Error, | ||
| "The function name has 'deprecated'"); | ||
| diagn.Report(fDecl->getLocation(), diagnID) | ||
| << fDecl->getNameInfo().getAsString(); | ||
| } |
There was a problem hiding this comment.
This is just a tip. It is your choice to apply it or not.
Suggested change
| if (isWarning) { | |
| diagnID = diagn.getCustomDiagID(DiagnosticsEngine::Warning, | |
| "The function name has 'deprecated'"); | |
| diagn.Report(fDecl->getLocation(), diagnID) | |
| << fDecl->getNameInfo().getAsString(); | |
| } else { | |
| diagnID = diagn.getCustomDiagID(DiagnosticsEngine::Error, | |
| "The function name has 'deprecated'"); | |
| diagn.Report(fDecl->getLocation(), diagnID) | |
| << fDecl->getNameInfo().getAsString(); | |
| } | |
| diagnID = diagn.getCustomDiagID( | |
| isWarning ? DiagnosticsEngine::Warning : DiagnosticsEngine::Error, | |
| "The function name has 'deprecated'"); | |
| diagn.Report(fDecl->getLocation(), diagnID) | |
| << fDecl->getNameInfo().getAsString(); |
m-ly4
approved these changes
May 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.