This repository was archived by the owner on Jan 19, 2025. It is now read-only.
Soloninko Andrey. Lab 3, opt 1 #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ly4
suggested changes
Apr 25, 2024
| MBIter != MachineBlock.end(); ++MBIter) { | ||
| if (MBIter->getOpcode() != llvm::X86::MULPDrr) { | ||
| continue; | ||
| } else { |
|
|
||
| # __m128d foo(__m128d a, __m128d b, __m128d c, __m128d d) { | ||
| # __m128d tmp = a * b; | ||
| # d = tmp + c; |
There was a problem hiding this comment.
Could you please provide more tests?
Like:
tmp = ab;
tmp2 = cd;
tmp3 = tmp + tmp2;
tmp = ab;
tmp2 = cd;
tmp3 = tmp2 + tmp;
tmp4 = tmp2 + tmp3;
| } else { | ||
| break; | ||
| } | ||
| continue; |
| llvm::MachineBasicBlock::iterator MulInstr = MBIter; | ||
| ++MBIter; | ||
| while (MBIter != MachineBlock.end()) { | ||
| if (MBIter->getOpcode() == llvm::X86::ADDPDrr) { |
There was a problem hiding this comment.
Suggested change
| if (MBIter->getOpcode() == llvm::X86::ADDPDrr) { | |
| if (MBIter->getOpcode() != llvm::X86::ADDPDrr) { | |
| break; | |
| } |
m-ly4
reviewed
Apr 25, 2024
llvm/lib/Target/X86/X86.h
Outdated
| @@ -167,6 +167,7 @@ FunctionPass *createX86LoadValueInjectionRetHardeningPass(); | |||
| FunctionPass *createX86SpeculativeLoadHardeningPass(); | |||
| FunctionPass *createX86SpeculativeExecutionSideEffectSuppression(); | |||
| FunctionPass *createX86ArgumentStackSlotPass(); | |||
| FunctionPass *createX86SoloninkoOptsPass(); | |||
m-ly4
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented an optimization pass that replaces multiplication and addition operation:
tmp = a * b;
d = tmp + c;
with muladd instruction:
d = muladd(a, b, c);