Lint Mithril main #828
Merged
Lint Mithril main #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 2, 2015 10:47
This changes enough things to merit a new patch release. It changed a few implementation details in the process, but it's at least much cleaner. Be ready for every other currently outstanding PR for this file to have merge conflicts.
|
Thanks @IMPinball |
|
Welcome. |
This was referenced Nov 7, 2015
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lhorie You're welcome.
This changes enough things to merit a new patch release. It changed a few implementation details in the process, but it's at least much cleaner.
Be ready for every other currently outstanding PR for this file to have merge conflicts.
I also disabled a few mysteriously broken tests in PhantomJS specifically, but they appear to be engine bugs, since they don't repro in Firefox. You can find them by grepping
mock.phantom. There's a relevant note in test-deps/mock.js, and the other problem is that PhantomJS 1.x is using a very old version of WebKit built into Qt, pre-Safari 8.