-
Notifications
You must be signed in to change notification settings - Fork 0
Conversion to ESM #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g test.mjs script
I've taken over this PR. It should be complete now, but I've requested @tegefaulkes to review it once before merging. After merging, @CDeltakai can start integration into polykey for addressing MatrixAI/Polykey#822. |
name: utils.decodeFilePath(data), | ||
type: utils.extractString(data, 156, 1), | ||
mode: utils.extractOctal(data, 100, 8), | ||
uid: utils.extractOctal(data, 108, 8), | ||
gid: utils.extractOctal(data, 116, 8), | ||
size: utils.extractOctal(data, 124, 12), | ||
mtime: utils.extractOctal(data, 136, 12), | ||
format: utils.extractString(data, 257, 6), | ||
version: utils.extractString(data, 263, 2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this PR, but there's a lot of magic numbers here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have constants corresponding to these magic numbers. Might've slipped my mind during initial implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fine.
Description
This PR converts the repository to ESM.
Issues Fixed
js-virtualtar
to ESM #3 (ENG-628)Tasks
Final checklist