fix: start with . #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./foo and foo are the same
whitty
reviewed
Feb 23, 2025
Comment on lines
+62
to
+67
| if let Some(Component::CurDir) = ita.clone().next() { | ||
| ita.next(); | ||
| } | ||
| if let Some(Component::CurDir) = itb.clone().next() { | ||
| itb.next(); | ||
| } |
There was a problem hiding this comment.
Should this be in the loop? what about "foo/./bar" and "foo/bar"
Maybe even in a while loop?
"././foo"and"foo"- or
"foo/././bar" and"foo/bar"`.
There was a problem hiding this comment.
@whitty At least after 1.31.0, components() will normalize the path: "Occurrences of . are normalized away, except if they are at the beginning of the path."
Manishearth
approved these changes
Feb 24, 2025
|
CI fails |
that may because I forget the utf8_paths module. Please try the CI again now. |
Manishearth
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./foo and foo are the same
fix #9