Skip to content

Fix TENO performance #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Fix TENO performance #807

merged 2 commits into from
Mar 15, 2025

Conversation

ChrisZYJ
Copy link
Contributor

Description

Fixes a performance issue in TENO-5/7 on CPUs that cannot optimize **6._wp. GPU performance is unaffected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Relative speeds (CPU and GPU speeds normalized with respect to their respective WENO3-JS):

performance

Absolute speeds (ns/gp/eq/rhs):

  CPU GPU
3J 8.02 1.73
3M 9.96 2.64
3Z 7.88 1.74
5J 9.82 2.29
5M 12.84 3.63
5Z 9.51 2.31
5T 9.91 2.60
7J 12.19 3.07
7M 16.18 4.87
7Z 11.47 3.14
7T 15.79 3.99
5T before 28.51 2.61
7T before 54.92 4.00

Legends:

  • 3/5/7: order
  • J: WENO-JS
  • M: WENO-M
  • Z: WENO-Z
  • T: TENO

Configuration:

  • 3D_performance_test
  • CPU tests on Richardson using 32 cores on one "rm" node
  • GPU tests on Delta using one GPU on one A40x4 node

@ChrisZYJ ChrisZYJ requested a review from a team as a code owner March 14, 2025 01:36
@ChrisZYJ ChrisZYJ changed the title Fix TENO speed Fix TENO performance Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.66%. Comparing base (e3572d1) to head (8b8926e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #807   +/-   ##
=======================================
  Coverage   43.65%   43.66%           
=======================================
  Files          65       65           
  Lines       19157    19159    +2     
  Branches     2338     2338           
=======================================
+ Hits         8363     8365    +2     
  Misses       9370     9370           
  Partials     1424     1424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson
Copy link
Member

Excellent PR. Thanks @ChrisZYJ. Merging.

@sbryngelson sbryngelson merged commit 93a1aac into MFlowCode:master Mar 15, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants