Skip to content

Updates and corrections to surface tension #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

wilfonba
Copy link
Contributor

@wilfonba wilfonba commented Nov 13, 2024

Description

This PR addresses issues brought up in recent discussions and issues regarding the documentation of surface tension. It also corrects a bug introduced in #688 where the surface_tension logical wasn't being MPI broadcast to all processes. It also adds extra checks to ensure the num_fluids = 2 and patch_icpp(i)%cf_val is specified for each patch. Adding these checks made me realize that the existing surface tension test cases were single fluid and, thus, not testing surface tension. This has also been corrected.

Fixes: #724 #720

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Ran examples/2D_laplace_pressure_jump and observed expected behavior.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.98%. Comparing base (a79e2e0) to head (252bfba).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   42.96%   42.98%   +0.01%     
==========================================
  Files          61       61              
  Lines       16314    16314              
  Branches     1882     1880       -2     
==========================================
+ Hits         7010     7013       +3     
+ Misses       8260     8259       -1     
+ Partials     1044     1042       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit b41386d into MFlowCode:master Nov 13, 2024
25 checks passed
@wilfonba wilfonba deleted the STDocs branch April 19, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update surface tension documentation
2 participants