Updates and corrections to surface tension #728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues brought up in recent discussions and issues regarding the documentation of surface tension. It also corrects a bug introduced in #688 where the
surface_tension
logical wasn't being MPI broadcast to all processes. It also adds extra checks to ensure thenum_fluids = 2
andpatch_icpp(i)%cf_val
is specified for each patch. Adding these checks made me realize that the existing surface tension test cases were single fluid and, thus, not testing surface tension. This has also been corrected.Fixes: #724 #720
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
Ran
examples/2D_laplace_pressure_jump
and observed expected behavior.