Skip to content

Including DoD Nautilus in the list of computers for MFC #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

JRChreim
Copy link
Collaborator

Description

This Pull Request introduces changes to the files toolchain/bootstrap/modules.sh and toolchain/modules and includes file toolchain/templates/nautilus.mako. They are updated/included so that MFC can be compiled on DoD Nautilus supercomputer. This commit does not add anything extra

Type of change

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

The changes have been tested by loading the associated modules and computers introduced in toolchain/bootstrap/modules.sh and toolchain/modules. MFC has been compiled on both CPU and GPU, and by performing the pipeline

./mfc.sh run /path_to_input/input.py run -t pre_process simulation -b mpirun

the simulations run adequately. We note that by simply doing

./mfc.sh test

does not work, with the following error reported:

Error: Submitting batch file for Interactive failed.

which happens as the command above cannot be appended to -b mpirun

Test Configuration:

  • What computers and compilers did you use to test this:

DoD Nautilus

Checklist

  • I have added comments for the new code
  • I ran ./mfc.sh format before committing my code
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

No

JRChreim added 3 commits July 15, 2024 18:14
…/modules.sh and toolchain/modules, and includes file toolchain/templates/nautilus.mako. They are updated/included such that MFC can be compiles on DoD Nautilus supercomputer. This commit does not add anything extra
@sbryngelson sbryngelson merged commit c6a94d4 into MFlowCode:master Jul 16, 2024
8 checks passed
@JRChreim JRChreim deleted the TestBranch branch July 16, 2024 02:04
AiredaleDev pushed a commit to AiredaleDev/MFC that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants