Skip to content

Improve Only Flag for Test #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Improve Only Flag for Test #518

merged 4 commits into from
Jul 11, 2024

Conversation

okBrian
Copy link
Contributor

@okBrian okBrian commented Jul 11, 2024

Description

Improved the Only Flag for `./mfc.sh test'
-o can now filter for any part of trace or the UUID rather than only UUID

Examples:

./mfc.sh test -l -o IBM
 >77CE10D6   2D -> 1 Fluid(s) -> IBM                             
   F13DF273   2D -> 1 Fluid(s) -> Viscous -> IBM                  
   B0CE19C5   2D -> 1 Fluid(s) -> Viscous -> IBM -> model_eqns=3  
   B9D934CF   2D -> 2 Fluid(s) -> IBM                             
   09E3930B   2D -> 2 Fluid(s) -> Viscous -> IBM                  
   7DCE34B4   2D -> 2 Fluid(s) -> Viscous -> IBM -> model_eqns=3  
   7CAA00A5   3D -> 1 Fluid(s) -> IBM                             
   150A86A6   3D -> 1 Fluid(s) -> Viscous -> IBM                  
   725A3D56   3D -> 2 Fluid(s) -> IBM                             
   0F6C4340   3D -> 2 Fluid(s) -> Viscous -> IBM   
./mfc.sh test -l -o IBM 3D
 >7CAA00A5   3D -> 1 Fluid(s) -> IBM                             
   150A86A6   3D -> 1 Fluid(s) -> Viscous -> IBM                  
   725A3D56   3D -> 2 Fluid(s) -> IBM                             
   0F6C4340   3D -> 2 Fluid(s) -> Viscous -> IBM   

Type of change

  • New feature (non-breaking change which adds functionality)

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

  • Test for only UUID ./mfc.sh test -l -o 7CAA00A5 (might need to change uuid since uuid can be different on different machine )
  • Test for components of trace ./mfc.sh test -l -o IBM 3D

Test Configuration:

Checklist

  • I have added comments for the new code
  • I ran ./mfc.sh format before committing my code
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

@okBrian
Copy link
Contributor Author

okBrian commented Jul 11, 2024

I'm not sure if this would better as its own flag but I feel like a 'filter' flag would do the same thing as an 'only' flag. This would just be nice for filtering specifically for examples when later implemented.

Copy link
Member

@henryleberre henryleberre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, @okBrian. Whoever had this idea needs a raise. 🚀

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.37%. Comparing base (99c91b8) to head (38d6156).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   58.37%   58.37%           
=======================================
  Files          57       57           
  Lines       14440    14440           
  Branches     1892     1892           
=======================================
  Hits         8429     8429           
  Misses       5449     5449           
  Partials      562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit a9c0e32 into MFlowCode:master Jul 11, 2024
21 of 22 checks passed
AiredaleDev pushed a commit to AiredaleDev/MFC that referenced this pull request Aug 7, 2024
@wilfonba wilfonba mentioned this pull request Sep 5, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants