Skip to content

Some cleanup tasks for chemistry following PR #653 #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbryngelson opened this issue Nov 5, 2024 · 0 comments · Fixed by #689
Closed

Some cleanup tasks for chemistry following PR #653 #680

sbryngelson opened this issue Nov 5, 2024 · 0 comments · Fixed by #689
Assignees
@henryleberre
Labels
enhancement New feature or request

Comments

@sbryngelson
Copy link
Member

Some cleanup tasks for chemistry following PR #653

  • Add chemistry capabilities to readme.md
  • Remove rogue print statement
  • Compile MFC with dummy mechanism to remove chemistry macros (test for performance to see if viable)
    • The above seems to also break cleanliness CI as mess with CodeCov
@sbryngelson sbryngelson added the enhancement New feature or request label Nov 5, 2024
henryleberre added a commit to henryleberre/CheMFC that referenced this issue Nov 5, 2024
@henryleberre
Dummy Chemistry Mechanism (MFlowCode#680)
258d9d9
@henryleberre henryleberre mentioned this issue Nov 5, 2024
Merged
henryleberre added a commit to henryleberre/CheMFC that referenced this issue Nov 5, 2024
@henryleberre
Dummy Chemistry Mechanism (MFlowCode#680)
b8a120a
sbryngelson pushed a commit that referenced this issue Nov 6, 2024
@henryleberre
Dummy Chemistry Mechanism (#680) (#689)
c36ce91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryleberre henryleberre

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dummy Chemistry Mechanism (#680) henryleberre/CheMFC
2 participants
@henryleberre @sbryngelson