References #6
Merged
References #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (i.e. transformations that do not map to a callable). We introduce a shared reference variant.
LukeMathWalker
added a commit
that referenced
this pull request
Feb 14, 2023
* Improve error message * Add test capturing the code that we'd like to compile. * Make the test red. Now we need to make it pass. * Parse shared references into a ResolvedType. * Test is green! * Add disclaimer to the generated code. * Update snapshots. * Add request scoped references to the test. * Handle references. * Introduce a `Constructor` enum that allows for inlineable transformations (i.e. transformations that do not map to a callable). We introduce a shared reference variant. * Handle references to request scoped types. * Test is green. * Transient references, yay! * Start trying to compile the generated code. Ouch. * Import types from `pavex_runtime` * Refactor `rustdoc` into multiple sub-modules. * More docs. * Add module docs. Refine visibility. * Index via PackageSpec * Rename methods. Pass collection as input to Crate::new * Move package spec logic into a new constructor. * _Almost_ back to green. * Workaround a bug in Rustdoc. * Fix all the "old" tests. * Fix reference bug. * Clean up the API for the rustdoc query module. * Refactor type resolution in ResolvedPath. * Tests are green again. * Enforce that resolution of a type happens using a fully qualified path. * Show off the example in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a bit carried away while working on this.
This PR:
pub use hyper::Server), if a module is re-exported (i.e.pub use hyper::body), if the entire crate is re-exported (i.e.pub use hyper) or if a glob is used (i.e.pub use hyper::*). I hopefully don't have to touch this stuff again.pavexwill feed a reference to your function - even if you technically are not allowed to because the type has been moved before.While working on this I found what looks like a bug in
rustdoc(rust-lang/rust#104064) - it probably means we won't be able to handle primitive types until it's resolved, I haven't fully tested its ramifications.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.