Skip to content

RSSI and SNR #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coljander opened this issue Sep 29, 2016 · 2 comments
Closed

RSSI and SNR #143

coljander opened this issue Sep 29, 2016 · 2 comments

Comments

@coljander
Copy link

Occasionally we are seeing weird RSSI and SNR values being reported. Although probably not related to our strange values, when looking at the code and I noticed a couple of things that I'm hoping you can clarify.

  1. In SX1272OnDio0Irq() the snr value that is eventually passed to OnRadioRxDone() is the value that is stored in the register and not the actual snr value. You use SX1272.Settings.LoRaPacketHandler.SnrValue, but the actual value appears to be stored in the snr variable, which is only ever used in the RSSI calculation. Am I reading that correctly? Up to now we've been reporting the SX1272.Settings.LoRaPacketHandler.SnrValue as the actual snr value which seems incorrect.
  2. In the same function, in the calculation for the Rssi value when snr < 0, you've used the 16/15 scaling factor which is suggested in the SX1272 spec. However the spec says that this scaling should only be applied when snr >=0. Does this make a big difference to the reported RSSI value for weak signals?

Thanks

@mluis1
Copy link
Contributor

mluis1 commented Sep 30, 2016

  1. Please take a look at Issues SNR value for MAC_DEV_STATUS_ANS #75 and SX1276 radio: reported SNR is wrong #104.
  2. For weak signals, it does not make a lot of difference, since RegPktSnrValue is small (hence the 16/15) has low effect. However, what the specification may overlook is the situation where RSSI is high and SNR is negative (high interference and signal below interference). In this case it is better to still apply the 16/15 factor, in order to have a better evaluation of the level of interference.

@coljander
Copy link
Author

Hi

Thanks for clearing this up. The issue can be closed.

Colin

From: Miguel Luis [mailto:[email protected]]
Sent: 30 September 2016 17:04
To: Lora-net/LoRaMac-node
Cc: Colin Anderson; Author
Subject: Re: [Lora-net/LoRaMac-node] RSSI and SNR (#143)

  1. Please take a look at Issues SNR value for MAC_DEV_STATUS_ANS #75SNR value for MAC_DEV_STATUS_ANS #75 and SX1276 radio: reported SNR is wrong #104SX1276 radio: reported SNR is wrong #104.
  2. For weak signals, it does not make a lot of difference, since RegPktSnrValue is small (hence the 16/15) has low effect. However, what the specification may overlook is the situation where RSSI is high and SNR is negative (high interference and signal below interference). In this case it is better to still apply the 16/15 factor, in order to have a better evaluation of the level of interference.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/143#issuecomment-250784091, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKB5apGpx3SvzFe0hE8EjmgUPCUMHJRlks5qvTLqgaJpZM4KJ-3p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants