-
-
Notifications
You must be signed in to change notification settings - Fork 28
refact: use yarn pack to generate package for testing #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41d14c3
to
306986a
Compare
ffe5ee0
to
6192d77
Compare
6192d77
to
ec09d47
Compare
danielpza
added a commit
that referenced
this pull request
Aug 7, 2024
Reverts the installation workaround introduced in #216. Since we changed the `ts-node` dev dependency to `@types/ts-node`, now it's not resolved by node's `require`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the generated tarball from
yarn pack
when running the tests. This way the dependencies resolution is more accurate to the user environment and we avoid some "hacks" using link: and file:Replaced npx calls with yarn
We might not need this workaround in yarn berry #199