Skip to content

refact: use yarn pack to generate package for testing #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 7, 2024

Conversation

danielpza
Copy link
Member

@danielpza danielpza commented Aug 6, 2024

Use the generated tarball from yarn pack when running the tests. This way the dependencies resolution is more accurate to the user environment and we avoid some "hacks" using link: and file:

Replaced npx calls with yarn

We might not need this workaround in yarn berry #199

@danielpza danielpza changed the title chore: replace npx with yarn refact: replace npx with yarn Aug 6, 2024
@danielpza danielpza changed the title refact: replace npx with yarn refact: replace link: protocol with file: in tests Aug 6, 2024
@danielpza danielpza changed the title refact: replace link: protocol with file: in tests refact: update tests Aug 7, 2024
@danielpza danielpza changed the title refact: update tests refact: use yarn pack to generate package for testing Aug 7, 2024
@danielpza danielpza marked this pull request as ready for review August 7, 2024 00:40
@danielpza danielpza requested a review from nonara August 7, 2024 00:40
@danielpza danielpza merged commit 0faf586 into master Aug 7, 2024
10 checks passed
@danielpza danielpza deleted the update-scripts branch August 7, 2024 01:09
danielpza added a commit that referenced this pull request Aug 7, 2024
Reverts the installation workaround introduced in
#216.

Since we changed the `ts-node` dev dependency to `@types/ts-node`, now
it's not resolved by node's `require`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant